Proxy not used for HTTPS URLs
Bug #1191669 reported by
István Váradi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Weather Indicator |
Fix Released
|
Medium
|
Joshua Tasker | ||
Bug Description
The proxy information is set only for the 'http' protocol, but not for 'https'. A possible fix is attached.
Revision history for this message
| István Váradi (ivaradi) wrote | #1 |
Revision history for this message
| Joshua Tasker (jtasker) wrote | #2 |
| Changed in weather-indicator: | |
| status: | New → Triaged |
| status: | Triaged → Fix Committed |
| importance: | Undecided → Medium |
| assignee: | nobody → Joshua Tasker (jtasker) |
| milestone: | none → 13.05.29 |
| Changed in weather-indicator: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks. Your patch is almost correct, but if there is no proxy set, it will raise a NameError when it tries to overwrite the empty dictionary (proxy_url is not set in that case). I've attached a corrected patch.