Comment 3 for bug 1628273

Revision history for this message
Jérôme Duriez (jduriez) wrote :

Hi,

Just to give some figures about this bug:
Random examples of triaxial simulations (with 20000 spherical particles and 6 boxes) show here ~ 45% of sphere-wall interactions that are useless at the end of the simulation. Ie ~ 3% of the (real) interactions total number.

I think checking for penetrationDepth < 0 around l.95 of the code [1], before deciding to "continue", would make sense and solve this bug.
OK ?

Do we take the opportunity to replace the shape test [2] with something else ? (what ? if yes)

Jerome

[1] https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ScGeom_CapillaryPhys_Capillarity.cpp#L95
[2] https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ScGeom_CapillaryPhys_Capillarity.cpp#L98