Fresh ubuntu-cli 12.04 project warn about PyGI

Bug #1007006 reported by Michael Terry
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Quickly
Fix Released
Undecided
Unassigned
quickly (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Vibhav Pant

Bug Description

[Impact]

When using the command line interface template (ubuntu-cli) in 12.04, you will repeatedly get warnings like:

WARNING: Your project is out of date. Newly created projects use
GTK+ 3, PyGI, and GSettings. See https://wiki.ubuntu.com/Quickly/GTK3 for
porting information and when you have finished porting your code, run
'quickly upgrade' to get rid of this message.

This is a scary warning and is false regardless. It comes from code that confuses ubuntu-cli with ubuntu-application and thinks the current project is out-of-date.

While this isn't a super popular template, it also affects any non-ubuntu-application template like the flash-game one or third party templates.

[Test Case]

cd /tmp
quickly create ubuntu-cli ubucli
cd ubucli
quickly run
# Notice warning

[Regression Potential]

The fix is tiny and only affects whether this warning is printed.

[Original Report]

In 12.04, if you do:

quickly create ubuntu-cli test-project
cd test-project
quickly run

You will see:

WARNING: Your project is out of date. Newly created projects use
GTK+ 3, PyGI, and GSettings. See https://wiki.ubuntu.com/Quickly/GTK3 for
porting information and when you have finished porting your code, run
'quickly upgrade' to get rid of this message.

Which is silly on a fresh project. This happens every run.

Why this occurs:

1) 'create' causes a .quickly file to be created with version 12.04 of ubuntu-cli
2) upgrade.py looks what version of ubuntu-application is saved, sees none and uses a default version of the empty string (to force all upgrades to happen).
3) The empty string causes the warning to be spit out and (correctly) exits before saving the latest version of ubuntu-application in .quickly.

A simple fix is to skip this warning when we encounter an empty string, since we know a fresh project is OK in regards to PyGI.

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in quickly (Ubuntu):
status: New → Confirmed
Michael Terry (mterry)
Changed in quickly:
status: New → Fix Committed
Michael Terry (mterry)
Changed in quickly:
milestone: none → 12.05
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quickly - 12.05-0ubuntu1

---------------
quickly (12.05-0ubuntu1) quantal; urgency=low

  * New upstream release
    - Fix ubuntu-flash-game backend to work (LP: #1007086)
    - For ubuntu-cli and ubuntu-flash-game, don't keep warning about
      upgrading the project to use PyGI, even on fresh projects
      (LP: #1007006)
    - Fix 'package --extras' and 'submitubuntu' to create packages suitable
      for the ARB process again (LP: #1003818, LP: #998910, LP: #1002417)
 -- Michael Terry <email address hidden> Thu, 31 May 2012 15:25:44 -0400

Changed in quickly (Ubuntu):
status: Confirmed → Fix Released
Michael Terry (mterry)
Changed in quickly:
status: Fix Committed → Fix Released
Michael Terry (mterry)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in quickly (Ubuntu Precise):
status: New → Confirmed
Vibhav Pant (vibhavp)
Changed in quickly (Ubuntu Precise):
assignee: nobody → Vibhav Pant (vibhavp)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted quickly into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in quickly (Ubuntu Precise):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
David Planella (dpm) wrote :

I've just run the test case and I can confirm that the precise-proposed package fixes the bug. Here's the output:

dpm@avenc:~$ cd /tmp
dpm@avenc:/tmp$ quickly create ubuntu-cli ubucli
Creating project directory ubucli
Creating bzr repository and committing
Launching your newly created project!
I'm launched and my args are:
Congrats, your new project is setup! cd /tmp/ubucli/ to start hacking.
dpm@avenc:/tmp$ cd ubucli
dpm@avenc:/tmp/ubucli$ quickly run
I'm launched and my args are:

No warning was shown.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quickly - 12.04-0ubuntu2

---------------
quickly (12.04-0ubuntu2) precise-proposed; urgency=low

  * debian/patches/fix-extras.patch:
    - Fix 'package --extras' and 'submitubuntu' to create packages suitable
      for the ARB process again (LP: #1003818, LP: #998910, LP: #1002417)
  * debian/patches/no-warn-on-fresh-cli.patch:
    - For ubuntu-cli and ubuntu-flash-game, don't keep warning about
      upgrading the project to use PyGI, even on fresh projects
      (LP: #1007006)
  * debian/patches/fix-flash-template.patch:
    - Fix flash game template to still use gtk2, as flash requires that
      (LP: #1007086)
  * debian/control:
    - Depend on webkit-1.0 and gtk-2.0 for above flash change
 -- Michael Terry <email address hidden> Thu, 31 May 2012 16:35:33 -0400

Changed in quickly (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.